Skip to content

Shipping Labels: Persist origin addresses upon fetching from remote #15932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 23, 2025
Merged

Shipping Labels: Persist origin addresses upon fetching from remote #15932

merged 5 commits into from
Jul 23, 2025

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jul 22, 2025 •
edited
Loading

Part of WOOMOB-627

Description

This PR adds a new Core Data entity for WooShippingOriginAddress and updates WooShippingStore to persist origin addresses in the local storage.

In the next PR, label purchase form will be updated to fetch addresses from the storage.

Testing steps

  • Build and run the app. Confirm that the app doesn't crash with the new entity added.
  • Log in to a test store with Woo Shipping extension set up.
  • Navigate to the Orders tab and select an order eligible for creating labels.
  • Select Create shipping label and confirm that origin addresses can still be loaded successfully.

Testing information

  • Tested and confirmed with simulator iPhone 16 iOS 18.4.
  • Added unit tests for Core Data migration and persisting origin addresses.

Screenshots

No UI changes.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 22.9 milestone Jul 22, 2025
@itsmeichigo itsmeichigo added feature: shipping labels Related to creating, ordering, or printing shipping labels. Enhancement labels Jul 22, 2025
@itsmeichigo itsmeichigo marked this pull request as ready for review July 22, 2025 05:49
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 22, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15932-367c36a
Version22.8
Bundle IDcom.automattic.alpha.woocommerce
Commit367c36a
Installation URL27a6aagu4asp0
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo mentioned this pull request Jul 22, 2025
Merged
1 task
@RafaelKayumov RafaelKayumov self-assigned this Jul 23, 2025
RafaelKayumov
RafaelKayumov approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works as described.

@itsmeichigo itsmeichigo merged commit 9db935b into trunk Jul 23, 2025
13 checks passed
@itsmeichigo itsmeichigo deleted the woomob-627-revisit-error-handling-for-a-failed-origin-address-load branch July 23, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelKayumov RafaelKayumov RafaelKayumov approved these changes

Assignees

@RafaelKayumov RafaelKayumov

Labels

Enhancement feature: shipping labels Related to creating, ordering, or printing shipping labels.

Projects

None yet

Milestone

22.9

Development

Successfully merging this pull request may close these issues.

4 participants

@itsmeichigo @wpmobilebot @RafaelKayumov